feat(ks,employer): remove referencable employment fields#3904
Draft
nikomakela wants to merge 1 commit intoYJDH-801-employer-1-form-viewfrom
Draft
feat(ks,employer): remove referencable employment fields#3904nikomakela wants to merge 1 commit intoYJDH-801-employer-1-form-viewfrom
nikomakela wants to merge 1 commit intoYJDH-801-employer-1-form-viewfrom
Conversation
YJDH-811. Some fields can be referenced through the link from EmployerSummerVoucher to YouthSummerVoucher, meaning that these values are already filled by youth, when they were requested from employer. Employer does not know and might not care about the data that should be added to those fields and they really are fields related to youth, not the employment, so they should not be asked from employer.
nikomakela
force-pushed
the
YJDH-801-employer-1-form-view
branch
from
337bd48 to
b0c8db8
Compare
nikomakela
force-pushed
the
YJDH-811-remove-dups
branch
from
80d8ff5 to
3727bc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YJDH-811.
Some fields can be referenced through the link from EmployerSummerVoucher to YouthSummerVoucher, meaning that these values are already filled by youth, when they were requested from employer. Employer does not know and might not care about the data that should be added to those fields and they really are fields related to youth, not the employment, so they should not be asked from employer.
Needs the API changes from #3903.